Fixed: Governance link to more details points to the same page#800
Fixed: Governance link to more details points to the same page#800richochetclementine1315 wants to merge 3 commits intocncf:mainfrom
Conversation
Signed-off-by: Mrinmoy_1315 <mrinmoymatilal1315@gmail.com>
github-project-automation
bot
moved this to 🆕 New
in TAG Contributor Strategy Project Board
|
@craigbox pls check the PR and kindly suggest changes :) |
| * What project resources are the province or responsibility of people who perform certain roles? | ||
|
|
||
| See the [section on Roles]() for more detail and examples of how to develop and document them for your project. | ||
| See the [section on Roles](https://contribute.cncf.io/maintainers/governance/overview/#roles) for more detail and examples of how to develop and document them for your project. |
There was a problem hiding this comment.
You're already on the correct page, so you should be able to do this:
| See the [section on Roles](https://contribute.cncf.io/maintainers/governance/overview/#roles) for more detail and examples of how to develop and document them for your project. | |
| See the [section on Roles](#roles) for more detail and examples of how to develop and document them for your project. |
| * If your project has elections, how are they conducted? | ||
|
|
||
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures]() for more detail. | ||
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures](https://contribute.cncf.io/maintainers/governance/overview/#policies-and-procedures) for more detail. |
There was a problem hiding this comment.
and here
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures](https://contribute.cncf.io/maintainers/governance/overview/#policies-and-procedures) for more detail. | |
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures](#policies-and-procedures) for more detail. |
Signed-off-by: Mrinmoy_1315 <mrinmoymatilal1315@gmail.com>
|
@craigbox hii sir...I've made the mentioned changes |
|
hey @craigbox can You please check it ones ?? :) |
|
@craigbox is anymore change required? |
I'm sorry to hear that! 😄 Assuming you're new to open source and the CNCF, please remember we're all volunteers in different parts of the world. Sometimes we're also on holiday, as is the case now. In this case, I raised a "drive by" issue when I was looking into this page, several months ago; I'm not really the right person to validate either the current state, or the fix. First, I had to work out how to validate it. As it stands, looking at the GitHub file, the links are already in the sections that are now being linked to - which I think was the initial complaint. I then had to figure out where this page is rendered - which is https://contribute.cncf.io/maintainers/governance/overview/#roles - and confirm the error was the same. Turns out the issue wasn't so much about making a two line change (which I could have done) but asking the author of the page the intention. You can't really know that, and they are probably the only people who can validate it. |
|
So, both of those links were meant to link to pages that have not been written. Instead, we got occupied with writing templates for projects. As such, the correct fix here is to take those two sentences and broken links out of the text. If we write the extra pages later on, we can put them back in. |
| * What project resources are the province or responsibility of people who perform certain roles? | ||
|
|
||
| See the [section on Roles]() for more detail and examples of how to develop and document them for your project. | ||
| See the [section on Roles](#roles) for more detail and examples of how to develop and document them for your project. |
There was a problem hiding this comment.
| See the [section on Roles](#roles) for more detail and examples of how to develop and document them for your project. |
There was a problem hiding this comment.
You may need to remove the blank line above also.
| * If your project has elections, how are they conducted? | ||
|
|
||
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures]() for more detail. | ||
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures](#policies-and-procedures) for more detail. |
There was a problem hiding this comment.
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. See the [section on Policies & Procedures](#policies-and-procedures) for more detail. | |
| There is a short list of P&P that every CNCF project is expected to have, and a slightly longer list that every project will want to have. |
Signed-off-by: Mrinmoy_1315 <mrinmoymatilal1315@gmail.com>
3 participants
Fixed the governance links. Fixed: the links in "policies and procedures" and "Role" section points to the same page
#715
@craigbox pls check :)